Skip to content

feat: Add some benches and integrate with Cosdpeed#62

Open
larseggert wants to merge 1 commit intomainfrom
feat-codspeed
Open

feat: Add some benches and integrate with Cosdpeed#62
larseggert wants to merge 1 commit intomainfrom
feat-codspeed

Conversation

@larseggert
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 27, 2026 11:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.72%. Comparing base (b0e6260) to head (113191e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files           2        2           
  Lines         754      754           
  Branches      754      754           
=======================================
  Hits          669      669           
  Misses         77       77           
  Partials        8        8           
Flag Coverage Δ
linux 88.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Congrats! CodSpeed is installed 🎉

🆕 8 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks


Open in CodSpeed

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a benchmark suite for the happy-eyeballs state machine and wires it into CI via CodSpeed to track performance over time.

Changes:

  • Added divan-style benchmarks covering several Happy Eyeballs scenarios (IPv6-only, dual-stack racing, HTTPS/ECH, many endpoints).
  • Integrated CodSpeed-compatible Divan dependency and registered the happy_eyeballs bench target.
  • Updated CI to run CodSpeed benchmarks and expanded coverage command to include all targets.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
benches/happy_eyeballs.rs New Divan/CodSpeed-compatible benchmark scenarios for the state machine.
Cargo.toml Adds CodSpeed Divan compat dev-dependency and declares the bench target (no harness).
Cargo.lock Locks new transitive dependencies introduced by CodSpeed/Divan compat.
.github/workflows/rust.yml Runs cargo bench --bench happy_eyeballs via CodSpeed; adjusts coverage run to --all-targets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@larseggert larseggert force-pushed the feat-codspeed branch 2 times, most recently from b12ebab to dd4addb Compare March 27, 2026 11:50
@larseggert
Copy link
Copy Markdown
Collaborator Author

@mxinden ready from my side. Can tweak the actual benches in follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants