Skip to content

feat(mozcloud): externalSecrets -> secrets in container defs, syntax fixes#218

Open
emaydeck-mozilla wants to merge 2 commits intomainfrom
change-secret-ref-name-containers
Open

feat(mozcloud): externalSecrets -> secrets in container defs, syntax fixes#218
emaydeck-mozilla wants to merge 2 commits intomainfrom
change-secret-ref-name-containers

Conversation

@emaydeck-mozilla
Copy link
Copy Markdown
Contributor

One bigger change and one smaller change:

  • Bigger change: container and initContainer definitions now allow you to specify secrets under secrets instead of externalSecrets.
    • This was already true previously, but has since been renamed and reworded to make things clearer and more accurate.
    • The readme has been updated to clarify what goes where.
    • New test cases were added to the external secrets test to ensure that we can mount secrets created outside this chart.
  • Smaller change: Removed unnecessary parentheses for some default statements. These still render the same way.

@emaydeck-mozilla emaydeck-mozilla self-assigned this Mar 26, 2026
@emaydeck-mozilla emaydeck-mozilla requested a review from a team as a code owner March 26, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant