-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Text Wrapping and Resizing for FreeText Annotations #18447
base: master
Are you sure you want to change the base?
Conversation
I just opened test/pdfs/freetexts.pdf with your patch applied, I tried to play with the gray squares and I'm sorry but I don't understand what it's supposed to do. I'm probably missing some context... |
Hello @calixteman, I have attached a screen recording that demonstrates the intended functionality of the FreeText annotations after applying my patch. Please review it at your convenience. If there are any areas that need improvement, I would appreciate your feedback. Thank you! |
Can you also test that when saving the PDF and re-opening it, the annotation text still wraps correctly? |
Hi @nicolo-ribaudo, I appreciate the feedback and I’m currently revising and improving the code to make it proficient as per the requirements. I will also test that when saving the PDF and re-opening it, the annotation text still wraps correctly. |
Ok I managed to do something similar to what you shew in your video. |
Hi @calixteman, To clarify, the primary issue I addressed was ensuring that FreeText annotations wrap text correctly. I have attached before and after screen recordings to demonstrate the resolved issues. Thank you for reviewing this. |
Hi @nicolo-ribaudo |
I am currently working on saving the PDF, reopening it, and displaying annotated wraps correctly. However, this task requires additional time as I need to understand the project's folder structure and codebase fully. Best regards, |
Description:
This PR introduces enhancements to the FreeTextAnnotationElement to ensure that text within the annotation wraps correctly.
Changes:
CSS Adjustments:
JavaScript Enhancements:
Testing: