Do not constantly render the detail canvas on zoom (bug 1952496) #19622
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be seen locally by setting the default delay in the app options to 999. |
When zooming, we should skip rendering the detail canvas until the zoom is done, similarly to how normal page rendering is delayed. To do so is enough to skip details view while zooming, since the main view rendering that already happens after the delay will also trigger rendering of the detail views.
nicolo-ribaudo
force-pushed
the
zoom-detail-view-constant-redraw
branch
from
0db7974 to
a1dc46a
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0738052fbb8e84c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e899b152717f4eb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0738052fbb8e84c/output.txt Total script time: 11.57 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e899b152717f4eb/output.txt Total script time: 26.68 mins
|
marco-c
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When zooming, we should skip rendering the detail canvas until the zoom is done, similarly to how normal page rendering is delayed. To do so is enough to skip details view while zooming, since the main view rendering that already happens after the delay will also trigger rendering of the detail views.