Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force language in tests #1819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreabergia
Copy link
Contributor

Fixes #1803

@rPraml
Copy link
Contributor

rPraml commented Feb 5, 2025

I would like to point out that it might be a bad idea to only run the tests in English.

In principle, I have nothing against changing it like that, but if we change it, then developers might not find errors in local build, that would, for example, appear in production in their language setting.

For example, my machine runs on de_DE and time zone Europe/Berlin and all tests are passing.

/edit: and the reason, why test runs in german locale is, that for the particular error message, there are translations only for "fr" and "zh_CN" ... and a german translation file is missing
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests assume that error messages are always in English
2 participants