WIP: fix #2

[luckylionheart]

CodeAnt-AI Description

Recognize periodic-table groups and common name variants in NLP queries

What Changed

• Added test mappings so queries that name element groups (for example "chalcogens", "period 2", "group 11", "tetrels") map to the correct element lists (e.g., "chalcogens" → O-S-Se-Te-Po).
• Accepts common phrasing, pluralization and different capitalizations for those group queries (examples: "all chalcogens", "CHALCOGENS", "period 2 elements", "Group 11").
• Added test cases that exercise boolean element-set expressions and compound element queries (AND/OR/ANY/ALL and parenthesized forms) and numeric comparisons/ranges for properties (e.g., "band gap>1.5" and "band gap>1.5 AND band gap<2.0").

Impact

✅ Correctly map "chalcogens" and variants to O-S-Se-Te-Po
✅ Allow queries like "period 2 elements" and "Group 11" to return the intended element sets
✅ Accept uppercase, plural and common-phrase variations for element-group searches

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

CodeAnt AI is reviewing your PR.

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[codeant-ai]

Suggestion: Avoid using replaceAll (not available in older Node.js / browser runtimes); use a compatible replacement such as .replace(/ /g, '_'). [compatibility]

Suggested change

	`elements HAS ALL "${parsed[categ].split('-').join('","')}"`
	filter.push(`_mpds_${parsed[categ].replace(/ /g, '_')} IS KNOWN`);

Why Change? ⭐

The proposed change replaces String.prototype.replaceAll (ES2021) with the widely-supported String.prototype.replace using a global regex (/ /g). Semantically both forms replace all literal space characters with underscores; using the regex preserves the original behavior while improving compatibility with older Node.js and browser runtimes that do not implement replaceAll. The improved line is valid JavaScript, uses only identifiers that exist in the surrounding code (parsed and categ), and keeps the same template literal structure, so it is executable and does not introduce new runtime errors. Assumptions: parsed[categ] is a string (same as in original code). Because this is a local, single-line, equivariant substitution with identical semantics for space characters, it is safe to mark as verified.

[codeant-ai]

Pull Request Feedback 🔍

🔒 No security issues identified

⚡ Recommended areas for review Dynamic regex risk / matching robustness check_category constructs a RegExp from term (user-provided) without escaping. If a crafted input contains regex metacharacters it may lead to unexpected matches or performance issues (long-running regex), and could cause false positives when matching mpds_props/mpds_classes. Element-group mapping The static mapping in ELEMENT_GROUPS_MAP for periods appears incomplete/incorrect (for example period 6 only contains Lu among the lanthanides instead of the full lanthanide sequence). This may cause incorrect results for queries like "period 6" or "period 6 elements". Numeric comparator parsing Numeric comparison test entries (e.g., "band gap>1.5", "band gap>1.5 AND band gap<2.0") assume the parser accepts no-space comparator forms. The parser may fail for queries with extra spaces or nonstandard spacing/Unicode comparators. Pre-normalizing comparators and validating parser behavior across whitespace variants is recommended. Plural normalization bug getGroupElements normalizes plurals by doing key.replace(/s$/i, ''). That removes a trailing "s" from the whole string, which corrupts multi-word group names like "noble gases" → "noble gase". Multi-word group plurals should remove the trailing "s" only from the last word. Fragile Normalization Many added variants rely on literal case/whitespace variants being listed explicitly (e.g., "period 2", "Period 2", "PERIOD 2", "period 2 elements"). This approach doesn't scale and can miss unlisted variants; a normalization layer (lowercase, strip plurals/stopwords) or a synonyms table would be more robust. Duplicate Entries Several mappings for the same semantic intent are duplicated (e.g. multiple "tetrel"/"Tetrels"/"ALL tetrels" entries and repeated "tetrel" lines). Duplicates increase maintenance cost and risk inconsistent updates across synonyms; canonicalization or a synonym->canonical mapping would be preferable. Incomplete / inconsistent group mappings The new ELEMENT_GROUPS_MAP contains many helpful entries but some period/group lists appear incomplete or inconsistent with the canonical periodic table (e.g., period 6/period 7 and placement of lanthanides/actinides). This can lead to surprising query results. Verify the element lists against a reliable source and add commonly used plural/alias forms as explicit keys or as part of a normalization mapping. Plural normalization bug The getGroupElements function normalizes plurals by removing a trailing "s" from the entire input string. This fails for multi-word plurals (e.g. "noble gases" -> "noble gase") and for words that pluralize with "es" (e.g. "chalcogenes" if present). As a result valid queries may not match keys in ELEMENT_GROUPS_MAP. Normalization performed at lookup time Currently the code lowercases and singularizes the input at lookup time (every call to getGroupElements). For performance and maintainability it would be better to precompute a normalized lookup map (including aliases/plurals) at module initialization so lookups are O(1) and consistent. Coverage Gaps / Missing Variants The new group/period tests cover basic case and punctuation variants but do not exercise many common alternate phrasings (e.g., "2nd period", "second period", "Group XI", "group eleven", "period II"). Add those to ensure normalization logic is robust. Maintainability Concern The test file is growing with many near-duplicate entries. Consider refactoring to a more compact representation (parameterized test cases or an array-of-variants per expected output) to keep intent clear and reduce churn when expectations change. Duplicate Tests Several identical or highly similar test entries are repeated (e.g., tetrel/tetrels, period 2 variants, group 11 variants). Duplication increases maintenance burden and can hide unintended inconsistencies between variants. Consider collapsing duplicates or generating variants programmatically. Redundant Entry The query "tetrel" appears multiple times with the exact same expected output. This redundancy can confuse test runners and reviewers; verify whether both entries are necessary.

[codeant-ai]

CodeAnt AI finished reviewing your PR.