Skip to content

Implement validator using Visitor pattern #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

record CorporateCustomer() implements Customer {
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

public sealed interface Customer permits CorporateCustomer, RegularCustomer, PremiumCustomer {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

public interface CustomerVisitor<T> {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

enum DiscountLevel {
BRONZE(10),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

public class DiscountProvider implements CustomerVisitor<DiscountLevel> {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

public class InvitationLetterGenerator implements CustomerVisitor<Letter> {

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

record Letter(String content) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

record PremiumCustomer() implements Customer {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

record RegularCustomer() implements Customer {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

import java.util.ArrayList;
import java.util.List;

class AggregatingValidationExceptionHandler implements ValidationExceptionHandler {

private List<ValidationException> errors = new ArrayList<>();

@Override
public void handle(ValidationException exception) {
errors.add(exception);
}

boolean hasErrors() {
return !errors.isEmpty();
}

public List<ValidationException> getErrors() {
return List.copyOf(errors);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

import java.util.regex.Pattern;

record Email(String address) {

public Email {
test(address, new ThrowingValidationExceptionHandler());
}

public static void test(String address, ValidationExceptionHandler handler) {
new EmailValidator().validate(address, handler);
}

static class EmailValidator implements Validator<String> {

public static final Pattern FORMAT_PATTERN = Pattern.compile("^[a-zA-Z0-9+_.-]+@[a-zA-Z0-9.-]+$");

@Override
public void validate(String address, ValidationExceptionHandler validationExceptionHandler) {
if (FORMAT_PATTERN.asMatchPredicate().negate().test(address)) {
validationExceptionHandler.handle(new InvalidFormatException());
}
}
}

static class InvalidFormatException extends ValidationException {
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

record Password(String value) {

public Password {
Password.test(value, new ThrowingValidationExceptionHandler());
}

public static void test(String password, ValidationExceptionHandler validationExceptionHandler) {
new PasswordValidator().validate(password, validationExceptionHandler);
}

static class PasswordValidator implements Validator<String> {

@Override
public void validate(String password, ValidationExceptionHandler validationExceptionHandler) {
if (password.length() < 8 || password.length() > 16) {
validationExceptionHandler.handle(new InvalidLengthException());
}
}
}

static class InvalidLengthException extends ValidationException {
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

class ThrowingValidationExceptionHandler implements ValidationExceptionHandler{

@Override
public void handle(ValidationException exception) {
throw exception;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

abstract class ValidationException extends RuntimeException {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

interface ValidationExceptionHandler {

void handle(ValidationException exception);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

interface Validator<T> {

void validate(T toValid, ValidationExceptionHandler validationExceptionHandler);
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor;
package pl.mperor.lab.java.design.pattern.behavioral.visitor.customer;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package pl.mperor.lab.java.design.pattern.behavioral.visitor.validator;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

class ValidatorVisitorTest {

@Test
public void testValidatePasswordAndEmailWithExceptionAggregation() {
var aggregationHandler = new AggregatingValidationExceptionHandler();
Password.test("xyz", aggregationHandler);
Email.test("user1$gmail.com", aggregationHandler);
Assertions.assertTrue(aggregationHandler.hasErrors());
Assertions.assertEquals(aggregationHandler.getErrors().size(), 2);
}

@Test
public void testValidatePasswordAndEmailWithExceptionThrowing() {
Assertions.assertThrows(Password.InvalidLengthException.class, () -> new Password("xyz"));
Assertions.assertThrows(Email.InvalidFormatException.class, () -> new Email("user1$gmail.com"));

var throwingHandler = new ThrowingValidationExceptionHandler();
Assertions.assertThrows(Password.InvalidLengthException.class, () -> Password.test("xyz", throwingHandler));
Assertions.assertThrows(Email.InvalidFormatException.class, () -> Email.test("user1$gmail.com", throwingHandler));
}
}