Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types for typescript #1055

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dbwodlf3
Copy link

@dbwodlf3 dbwodlf3 commented Dec 23, 2021

I added types for typescript.
I would like to devlop in typescript env.

I know pannellum is not commonjs working. it works only on browser.

It doesn't work in commonjs but anyway i can get typehinting

@mpetroff
Copy link
Owner

The index.d.ts file looks like it was automatically generated. How was this done?

My tendency is to not merge this as is, since it is an additional maintenance burden for something I don't use and am not in a position to test. Furthermore, the comments are all copied into an additional file and need to be maintained in two places. If there's a straightforward way to automatically generate the types, I'd consider including such a script, the output of which could potentially be included in releases, similar to how the minified files are generated for releases. However, the lack of testing would still be an issue.

@dbwodlf3
Copy link
Author

dbwodlf3 commented Dec 27, 2021

actually it is written by hand. i will find and update it (automated index.d.ts from source code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants