Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sticky" option to hot spots #1195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Malgalad
Copy link

A barebones proposal to cover #1193. If hot spot has a new option sticky set to truthy value, then hot spot coordinates are clamped to always be within canvas space.

It seems to be working for me and does cover the basic functionality, but I am open to updates if it requires more configuration or logic. E.g. more padding, pointing arrows, not dispatching events unless hot spot should be visible without clamping, maybe some crowding logic so multiple hot spots don't collapse into one in a corner...

@mpetroff
Copy link
Owner

mpetroff commented Jan 7, 2024

This implementation is flawed. It doesn't handle hot spots that are >90 deg from the center of the view, and the vertical position of these indicators should not move when panning only in yaw. Furthermore, there would need to be some sort of visual indicator that these hot spots are actually off the edge of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants