Skip to content

bug: check server config #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug: check server config #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a02c2
check server check.
Txiaozhe Jul 25, 2019
4747714
Update index.js
Txiaozhe Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ module.exports = function(serverConfig, sharedConfig, clientStreamHandler){
server = createWebSocketServer(clientStreamHandler);
} else if(config.protocol == 'wss') {
server = createSecureWebSocketServer(config.ssl, clientStreamHandler);
} else {
throw new Error('negative attach and unknow protocol');
}

server._css_host = config.host;
Expand Down
20 changes: 20 additions & 0 deletions tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,24 @@ describe('create-stream-server', function(){
});
});
});

it('should throw error if negative attach and unknow protocol', function(done) {
try {
var servers = css({
s1: {
attach: null,
protocol: 'unknow-protocol',
host: 'localhost',
port: 9010
}
}, function() {});
} catch(err) {
assert.deepStrictEqual(
err,
new Error('negative attach and unknow protocol'),
'negative attach and unknow protocol should error'
);
done();
}
})
});