Use lets-encrypt for certs #32
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 375 379 +4
Branches 38 40 +2
=========================================
+ Hits 375 379 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmmaLRussell
left a comment
EmmaLRussell
left a comment
There was a problem hiding this comment.
I guess this is quite tricky to test manually! Is there a staging environment for ncov where we can test this? Can it be tested locally?
You'll need to bump up the version in src/packit_deploy/__about__.py
Also, should update the "complete" config (for local testing if possible).
|
For https://github.com/ncov-ic/ncov-packit/ I get a 404 page (permissions?) so I'm quite unsure of the context of this change... what does using LetsEncrypt achieve? |
Co-authored-by: Emma Russell <[email protected]>
| if cfg.use_acme: # pragma: no cover | ||
| vault.resolve_secrets(cfg.acme_config, cfg.vault.client()) |
There was a problem hiding this comment.
For another time - if constellation's AcmeBuddyConfig had been a dataclass you would get this for free now: reside-ic/constellation#38
There was a problem hiding this comment.
Nice - I'll do that...
This wires in acme-buddy, via constellation, for packit deployments.