Use jinja2 to generate the nginx configuration. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
force-pushed
the
type-annotations
branch
from
dc594f3 to
c92108c
Compare
Member
Author
|
I'm not really how to get changes to the proxy to pass CI. I'm pretty sure the failure is because it is using whatever is on ghcr rather than the in-tree modified version. Locally I build the proxy image with |
plietar
force-pushed
the
type-annotations
branch
from
c92108c to
7bc88b2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 98.66% 98.10% -0.56%
==========================================
Files 4 4
Lines 450 476 +26
Branches 39 41 +2
==========================================
+ Hits 444 467 +23
- Misses 5 7 +2
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Done. Depends on reside-ic/constellation#40. |
plietar
force-pushed
the
type-annotations
branch
from
b495a45 to
18d2427
Compare
plietar
force-pushed
the
jinja-proxy
branch
2 times, most recently
from
e4c9860 to
1873201
Compare
The test broke when I changed acme-buddy's key type. I think verifying the signature is a bit overkill. As long as the certificate is there I think that is enough.
We used to have a dictionary for all the container names. This will become a bit unwieldy once we have many replicas of a container. Instead the names are put as fields of the correspoding container configuration objects, usually as constants. Additionally stop putting the constellation container prefix in the URLs. It turns out that constellation sets up networking such that these are not needed.
The configuration is now generated from Python instead of inside the container. This gives us much more flexibility than envsubst, including the ability to have for-loops. This will allow us to have multiple server blocks in a multi-packit configuration.
Previously the integration tests were always using the proxy image from GHCR. This makes changes to the proxy difficult. The new `build` option allows a path to a directory containing a Docker file to be specified in place of a name and tag. We use it for the proxy everywhere.
Simplify the way container names are handled.
EmmaLRussell
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration is now generated from Python instead of inside the container. This gives us much more flexibility than envsubst, including the ability to have for-loops. This will allow us to have multiple server blocks in a multi-packit configuration.