Add file completion for output flag

mrclmr · Aug 10, 2023 · 5534d3f · 5534d3f
1 parent 11f062b
commit 5534d3f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/cmd/icm/download_owners.go b/cmd/icm/download_owners.go
@@ -38,7 +38,7 @@ func newDownloadOwnersCmd(
 	timestampUpdater data.TimestampUpdater,
 	ownersDownloader http.OwnersDownloader,
 	ownerCSVPath string,
-) *cobra.Command {
+) (*cobra.Command, error) {
 	filePath := filePathValue{value: ownerCSVPath}
 
 	downloadOwnersCmd := &cobra.Command{
@@ -58,14 +58,20 @@ icm download-owners
 # Use semicolon as a separator. For using double quotes please see existing
 # owner.csv file.
 echo 'AAA;my company;my city;my country' >> $HOME/.icm/data/custom-owner.csv`,
-		Args: cobra.NoArgs,
+		Args:              cobra.NoArgs,
+		ValidArgsFunction: cobra.NoFileCompletions,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return overwriteOwnersFile(writeOwnersCSVFunc, timestampUpdater, ownersDownloader, filePath.value)
 		},
 	}
 	downloadOwnersCmd.Flags().VarP(&filePath, "output", "o", "output file")
 
-	return downloadOwnersCmd
+	err := downloadOwnersCmd.MarkFlagFilename("output")
+	if err != nil {
+		return nil, err
+	}
+
+	return downloadOwnersCmd, nil
 }
 
 func overwriteOwnersFile(writeOwnersCSV data.WriteOwnersCSVFunc, timestampUpdater data.TimestampUpdater, ownersDownloader http.OwnersDownloader, filePath string) error {

diff --git a/cmd/icm/root.go b/cmd/icm/root.go
@@ -154,7 +154,11 @@ Visit github.com/meyermarcel/icm for more docs, issues, pull requests and feedba
 		return nil, err
 	}
 	rootCmd.AddCommand(cmd)
-	rootCmd.AddCommand(newDownloadOwnersCmd(ownerCreator, timestampUpdater, ownersDownloader, ownerCSVPath))
+	downloadOwnersCmd, err := newDownloadOwnersCmd(ownerCreator, timestampUpdater, ownersDownloader, ownerCSVPath)
+	if err != nil {
+		return nil, err
+	}
+	rootCmd.AddCommand(downloadOwnersCmd)
 	rootCmd.AddCommand(newDocCmd(rootCmd))
 
 	return rootCmd, nil