Show Muse Weekly Above the Fold With the Meta Mark - #122
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
🟢 Approval recommended
The schema bump, migration logic, default layout updates, icon swap, and documentation are consistent and have targeted regression tests.
Pull request overview
Updates Runway’s Muse provider defaults so Weekly Usage is shown above the fold, both Muse meters are pinned to the menu bar by default, and the provider icon uses Meta’s infinity‑M mark—while migrating existing user layouts forward without requiring a reset.
Changes:
- Adjusts default layout so
muse.weeklyis no longer an On Demand metric and both Muse meters are default-pinned. - Adds a v6 settings migration to promote Muse Weekly and add Muse pins for existing installs.
- Replaces the Muse provider SVG with Meta’s infinity‑M mark and adds/updates regression tests + docs.
File summaries
| File | Description |
|---|---|
| Tests/RunwayTests/SettingsMigratorTests.swift | Adds coverage for the new v6 migration behavior (removing muse.weekly from expanded lists and pinning both Muse meters). |
| Tests/RunwayTests/ProviderMarksTests.swift | Verifies the Muse provider mark loads the new Meta infinity‑M SVG path and has sane bounds. |
| Tests/RunwayTests/MuseProviderTests.swift | Updates Muse layout expectations to reflect both meters being always visible and pinned by default. |
| Sources/Runway/Stores/DefaultLayout.swift | Makes Muse session + weekly enabled/pinned by default and removes Muse from default On Demand membership. |
| Sources/Runway/Resources/ProviderIcons/muse.svg | Replaces the old sparkle icon with the monochrome Meta infinity‑M path (currentColor). |
| Sources/Runway/App/SettingsMigrator.swift | Bumps schema to v6 and adds migration logic to promote Muse Weekly + add Muse pins. |
| docs/providers/muse.md | Documents that both Muse meters start always visible and starred in the menu bar. |
| docs/dashboard.md | Updates dashboard docs to include Muse in the “Five-Hour + Weekly always visible” default description. |
Review details
- Files reviewed: 7/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Weekly shipped below the caret and neither meter was starred. Promote it under Five-Hour Usage, pin both, and swap the sparkle for Meta's infinity-M.
495ccce to
db6490a
Compare
TL;DR
Muse Weekly Usage now sits under Five-Hour Usage as an Always Visible row. Both meters are starred, and the card uses Meta's infinity-M mark.
What was happening
What this changes
muse.svgis Meta's infinity-M path (monochrome,currentColor).Tests