Split out samply-debugid crate #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I agree, relative_base_address is the one other thing that came to mind. Maybe we should also add a samply-object crate, and then move debug_id_for_object and relative_address_base into it? Then samply-debugid doesn't need a dependency on object. We could even make samply-object define an ObjectExt trait if we wanted. |
|
I'll merge this as-is, but let me know your thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #684
Looking through
samply-symbols/src/shared.rsI was wondering if there's anything else worth breaking out for use when writing profiles. For example I used the ELF part ofrelative_base_address(although this is quite small so I'm not sure this function in particular is worth it).