Line numbers start at 1 #2804
Merged
Line numbers start at 1 #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skgland
reviewed
Feb 1, 2025
tests/scryer/main.rs
Outdated
Comment on lines
24
to
25
| .case("tests/scryer/cli/issues/*.toml") | ||
| .skip("tests/scryer/cli/issues/singleton_warning.toml") // wrong line number | ||
| .case("tests/scryer/cli/issues/singleton_warning.toml") |
There was a problem hiding this comment.
The skip can be removed without adding a new case as it should be covered by the glob above.
There was a problem hiding this comment.
Should we delete the associated files for that issue too?
$ find . -name 'singleton_warning*'
./tests/scryer/cli/issues/singleton_warning.stderr
./tests/scryer/cli/issues/singleton_warning.in
./tests/scryer/cli/issues/singleton_warning.stdin
./tests/scryer/cli/issues/singleton_warning.toml
./tests/scryer/cli/issues/singleton_warning.stdout
There was a problem hiding this comment.
It's rarely a good idea to delete tests. I suggest we keep them.
There was a problem hiding this comment.
Got it, thanks. I've removed the skip.
Bumps the line number for the singleton warning. When the singleton
occurs on the same line at the term starts, the line number is correct:
foo(X).
However it stills mis-reports this line number as 1 instead of 5:
foo(1) :-
true,
true,
true,
Y.
See issue mthom#1356.
dnmfarrell
force-pushed
the
line-count-off-by-one
branch
from
2ca683c to
f509d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick (partial) fix the the singleton warning line number. See what you think!
Bumps the line number for the singleton warning. When the singleton occurs on the same line at the term starts, the line number is correct (e.g.line 1 instead of 0):
However it stills mis-reports this line number as 1 instead of 5:
See issue #1356.