Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DolphinDB VSCode Extension for SQLTools #1435

Closed
wants to merge 2 commits into from
Closed

Conversation

ffliu29
Copy link

@ffliu29 ffliu29 commented Feb 10, 2025

This pull request introduces the DolphinDB VSCode Extension for SQLTools, enabling support for connecting to and interacting with the DolphinDB database through SQLTools. As part of this implementation, a new package, driver.dolphindb, has been added to the packages directory.

We have developed this extension to integrate DolphinDB with SQLTools. However, the project requires a Node.js v22 environment due to the use of the --experimental-transform-types compilation option, which is not supported in Node.js v20 (the current version used in the dev branch).

If merging this pull request into the main dev branch is not feasible due to the Node.js versioning conflict, we kindly request testing the extension independently in a Node.js v22 environment. Alternatively, would it be possible to create an official repository for the DolphinDB VSCode Extension for SQLTools? This would ensure the extension remains an official addition to SQLTools while being maintained independently.

Thank you for your time and consideration. We look forward to contributing to the SQLTools ecosystem!

@gjsjohnmurray
Copy link
Collaborator

Thank you for your interest in contributing. However, new drivers need to be standalone extensions with their own repo, and published on Marketplace under your own publisher id.

It sounds like your driver will require the SQLTools extension to be migrated to NodeJS 22. In #1419 we recently moved to version 20 but we haven't yet released this.

Are you willing to prepare a PR that only updates to version 22?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants