-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PyQt5, increases Python version compatibility #2487
base: master
Are you sure you want to change the base?
Conversation
1eee3f3
to
79701ca
Compare
bc49128
to
fe87b39
Compare
While running the Bullseye CI, sotimes this exception is encountered:
But this turns out to be an issue in the Python standard library: All Bullseye releases ship 3.9.2 and the issue is resolved in 3.9.10: Restarting the CI job is likely to "workaround" the issue. |
fe87b39
to
7a92b3e
Compare
854e1aa
to
e086cbe
Compare
In Windows 10, if you press the REPL button in Python mode, you can see the error below:
|
Thanks for testing @JeongJun-Lee! |
As discussed in #2423 pygame version 2.5.1 should have fixed the issue with older macOS releases. So, we can remove this max version clamp.
84c3656
to
e81ebf0
Compare
e81ebf0
to
9a0f269
Compare
To be merged after we releases 1.2.x.
As this drops compatibility with macOs 10.12 Sierra, and older Python releases, this could probably be released as v1.3.0.
Locking PyQt5 to version
5.15.10
instead of the latest5.15.11
release, because5.15.11
jumps from macOS 10.13 to 11 , dropping 3 major macOS releases.*1
*2
*3
*1
In theory this should work, but haven't got access to an arm mac to test, CI on arm64 mac does pass*2
Not tested yet in Bookworm*3
Ubuntu 18.04 supported by Qt 5.15, but it ships Python 3.6, which is not supported by PyQt5 5.15.7+