fix(LTX25-DEVICE-RESIDENCY): bound each leaf record on its own, because the span-slack bound reds an unmutated tree and its multiplier came from the artifact (#1559) - #1582
Merged
Conversation
…se the span-slack bound reds an unmutated tree and its multiplier came from the artifact (#1559) Assertion (1c) in `test_ltx2_video` landed in 6b48edb to un-red `build-test-cpu`. It reds that lane itself. Measured at that head, unmutated, one binary and one build directory: five of 53 runs red, worst 10.032 ms of head-plus-tail against a 0.25 ms bound. Three defects, and the constant is only the first. Raising it could not have been enough, because the `0.5 * leaf_seconds` cap forbids any useful bound on a short record: `artifacts.frames` measured 1.361 ms of slack on a 4.826 ms record, and `decode.video`'s reopen record is 19-89 us of which 4.6-72.3% is its own two boundaries. The multiplier was `leaves.size()`, read from the table under test and tied to no independent number, so a defect emitting one extra leaf record enlarged its own budget. The slack was summed as well, so one record of a three-record leaf could spend the whole thing. The comment claiming the sum was stricter on multi-record leaves was false, and the looseness was load-bearing. The failure message said this quantity does not move with the box. Within one build configuration on one host it spans 402x. Each leaf record is now bounded separately against one 30 ms constant, 2.99x the worst of 636 observations. `leaves.size()` leaves the arithmetic. The `min` cap moves to the record, which makes the forced-strict probe red by construction, and where that cap binds the record is declared below the instrument's resolution and held by the coverage floor instead. A new `REQUIRE(c.min_coverage >= 0.5)` makes that hand-off executable. The two per-configuration constants collapse to one, because the plain lane's own scheduler tail is now three times the largest sanitizer slack ever recorded. Forced-strict reds 9 of 9 checked records. A 45 ms swallow injected into one record passes the old formula on `decode.video` and reds the new one at the identical constant. 40 runs of the repaired shape across three load configurations are green. What the repair can no longer see is stated at the site and under `## Owed`. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
FOLLOWING_AGENTS_PROTOCOL The branch was cut at 6b48edb and origin/main advanced seven commits while the span-slack distribution was being measured. None of them touches `test_ltx2_video` or this row's spec, and the only overlap is an append to `.agents/issue-index.md`, which the union driver merges. The gate is rerun at this head. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
FOLLOWING_AGENTS_PROTOCOL The branch was cut at 6b48edb and origin/main advanced while the span-slack distribution was being measured. None of them touches `test_ltx2_video` or this row's spec, and the only overlap is an append to `.agents/issue-index.md`, which the union driver merges. The gate is rerun at this head. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
FOLLOWING_AGENTS_PROTOCOL origin/main advanced again while #1582 was in fresh review. Neither incoming commit touches `test_ltx2_video` or this row's spec, and the only overlap is an append to `.agents/issue-index.md`, which the union driver merges. Taken so that `check-commit-style --range origin/main..HEAD` has an ancestor base again. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
…through, instead of naming an assertion that does not bind there (#1559) A fresh review of #1582 measured two claims in the record that a smaller batch had supported and a bigger one does not. Neither changes the assertion or the constant. Both change what a reader is told the assertion still covers, which is what a fifth reviewer will act on. The constant was argued to be bounded from above by `decode.video` record 0 staying over the 60 ms floor on two cores. It does not stay over it. Over 35 runs of the repaired shape that record fell below the floor in 4 of 60 shared-box observations and 8 of 30 two-core observations, the checked minimum on two cores was 62.6 ms, and in 2 of 20 shared-box runs the whole leaf left the gated set. CI's runner is faster than that box, so it straddles there too. The conclusion survives on `denoise` and `decode.audio`, which are gated in 35 of 35 runs, are seconds long everywhere measured, and hold over 96% of the leaf-seconds. Only the stated reason was wrong, and the correction says so rather than replacing the sentence silently. The hand-off to the coverage floor is exact only for a leaf of one record, where `covered >= 0.5 * leaf_seconds` IS the capped span bound. Of the skipped classes only `artifacts.frames` on the nine-frame render is that shape. On `decode.video`'s reopen records the floor at 0.90 permits 17-139 ms of a 0.17-1.39 s leaf while the records themselves are 0.019-5.66 ms, so a swallow may grow one to just under 60 ms, up to 94x its honest size, and neither assertion sees it. The prose already said what escapes; the table beside it named an assertion instead, and the table is what gets read. Both tables now carry the escape as a ceiling, and the site scopes its argument to single-record leaves. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
FOLLOWING_AGENTS_PROTOCOL origin/main advanced again while #1582 was in fresh review. Neither incoming commit touches `test_ltx2_video` or this row's spec, and the only overlap is an append to `.agents/issue-index.md`, which the union driver merges. Taken so that `check-commit-style --range origin/main..HEAD` has an ancestor base again. Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5-1m [Claude Code]
localai-bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
…urrent landing) `f38cd69e7` (#1582) landed the per-record bound and appended its own `.agents/issue-index.md` row. This row appends a second, for a different issue, and the two appends are exactly the case `merge=union` exists for: `merge-tree` reports the result clean locally while GitHub reports the file CONFLICTING, because the forge ignores the driver. Merging rather than rebasing keeps the reviewed SHA intact. Verified after the merge that main's rows are all present and this branch contributes exactly its own, with no issue number appearing twice. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [Claude Code]
localai-bot
pushed a commit
that referenced
this pull request
Aug 21, 2026
…bound, and delete the paragraph that still described this row's withdrawn one `origin/main` moved to `f4ccabbb4` and `f38cd69e7` (#1582) rewrote the same region of `tests/vllm/multimodal/test_ltx2_video.cpp` that this branch touched. Only one hunk conflicted and BOTH SIDES OF IT ARE COMMENT LINES, which was asserted programmatically rather than read off the diff: the resolution script refuses if either side carries a non-comment line. **The two sides had already converged on the same assertion.** `65e681438` withdrew this row's `residue <= 2 * instrument` bound after a third review measured it red 4 times in 45, so this branch ends at `covered >= c.min_coverage * leaf_seconds` -- the tree's own share floor, unedited. That is exactly what `main` carries. The conflict was therefore two descriptions of one line, and `main`'s is the one that describes it correctly. **So the whole `(2) COVERAGE` comment is restored to `main`'s bytes.** The paragraph the auto-merge kept was this branch's, and it was stale on this branch's own head: it says the share floor "is DELETED rather than moved again" and that "the line below permits twice an instrument charge", two lines above a `CHECK_MESSAGE` that keeps the floor and a `MESSAGE` that prints the instrument ratio as "REPORTED not asserted". It also contradicted the paragraph directly under it, which `main` had rewritten to say "NOTHING WAS DELETED to get here". That paragraph auto-merged WITHOUT a conflict, so nothing in the merge machinery would have caught it. The PR body already states the correct position -- the bound is withdrawn, the floors are the tree's own -- so this only brings the file into line with the body. **`main`'s span-slack repair is taken whole.** `f38cd69e7` replaced the summed bound and its sanitizer-conditional constant with a per-record 30 ms bound that skips records below its own resolution. That region auto-merged because this branch never changed it. Verified by stripping comments from both files and diffing: every remaining code delta against this branch's head belongs to that repair, and the merge introduces no line neither parent carried. `.agents/issue-index.md` merged as a pure union-append, checked by multiset against both parents: no parent line dropped, altered, or invented. 538 and 539 lines in, 547 out. `test_ltx2_video` is NOT run here. It reaches 30-36 GB of anon-RSS and this box is at load 31, which is the regime its own load-sensitive assertions are weakest in. The CI lane is the gate for this merge. FOLLOWING_AGENTS_PROTOCOL Following-Agents-Protocol: true AI-Assisted: true Assisted-by: AGENT:claude-opus-5 [claude-code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertion (1c) in
test_ltx2_videolanded in6b48edb2cto un-redbuild-test-cpu. It reds that lane itself. Measured at that head, unmutated,one binary and one build directory: five of 53 runs red, worst 10.032 ms of
head-plus-tail against a 0.25 ms bound.
Three defects, and the constant is only the first. Raising it could not have
been enough, because the
0.5 * leaf_secondscap forbids any useful bound on ashort record:
artifacts.framesmeasured 1.361 ms of slack on a 4.826 msrecord, and
decode.video's reopen record is 19-89 us of which 4.6-72.3% is itsown two boundaries.
The multiplier was
leaves.size(), read from the table under test and tied tono independent number, so a defect emitting one extra leaf record enlarged its
own budget. The slack was summed as well, so one record of a three-record leaf
could spend the whole thing. The comment claiming the sum was stricter on
multi-record leaves was false, and the looseness was load-bearing.
The failure message said this quantity does not move with the box. Within one
build configuration on one host it spans 402x.
Each leaf record is now bounded separately against one 30 ms constant, 2.99x the
worst of 636 observations.
leaves.size()leaves the arithmetic. Themincapmoves to the record, which makes the forced-strict probe red by construction,
and where that cap binds the record is declared below the instrument's
resolution and held by the coverage floor instead. A new
REQUIRE(c.min_coverage >= 0.5)makes that hand-off executable. The twoper-configuration constants collapse to one, because the plain lane's own
scheduler tail is now three times the largest sanitizer slack ever recorded.
Forced-strict reds 9 of 9 checked records. A 45 ms swallow injected into one
record passes the old formula on
decode.videoand reds the new one at theidentical constant. 40 runs of the repaired shape across three load
configurations are green. What the repair can no longer see is stated at the
site and under
## Owed.A fresh review then measured two claims in the record that a smaller batch had
supported. The constant is not bounded from above by
decode.videorecord 0, asthis branch first argued: over 35 runs that record fell below the 60 ms
resolution floor in 4 of 60 shared-box and 8 of 30 two-core observations, and in
2 of 20 shared-box runs its leaf left the gated set entirely.
denoiseanddecode.audioare what bound the constant, gated in 35 of 35 runs and holdingover 96% of the leaf-seconds. And the hand-off to the coverage floor is exact
only for a single-record leaf; on
decode.video's reopen records a swallow mayreach the 60 ms floor, up to 94x their honest size, unseen by either assertion.
Both tables now carry that escape as a ceiling instead of naming an assertion
that does not bind there, and the site scopes its argument. The assertion and the
constant are unchanged by that correction.
Reported and owned by #1559. Context: #1494 and #1499, both closed, are what
#1503 repaired; this change repairs the repair. #1439 stays untouched and is
still owed the same thing this bound is: a name on the un-named time.
FOLLOWING_AGENTS_PROTOCOL
Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:claude-opus-5-1m [Claude Code]