Repository navigation
Conversation
Also returns undefined explicitly when there is no viewport.
Janpot
added
performance
component: scroll area
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 4m 12s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
not a significant perf improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each Scroll Area measured its viewport and wrote its thumb sizes and offsets in one go, so mounting many of them forced a synchronous layout per instance. The measurement now reads first and returns its writes; Scroll Areas measuring in the same task queue in one microtask that runs every read before any write.
The smoke comment below doesn't list it: its 60 one-line Scroll Areas lay out too cheaply for the forced layouts to show. Locally against master (99% intervals), the smoke case shows no change detected, and mounting 300 Scroll Areas with 20 lines of overflowing content each improves paint by only 0.1% to 3.3% (90.8 ms to 90.0 ms), with render unchanged.
Split out of #5974.