Repository navigation
Conversation
Janpot
added
component: slider
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 4m 05s · details Smoke · Slider
Medians; Δ is the confidence interval of the paired per-round difference (99%). Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Janpot
marked this pull request as ready for review
October 27, 2026 16:27
Janpot
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
October 27, 2026 16:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registered thumbs lived in Root's state, so every Slider part re-rendered when the thumbs registered on mount. Only
Slider.Valuereads them (for itshtmlFor), so they now live in a store it subscribes to on its own. The thumbs also guess their composite index from render order, which avoids their own re-render after mount.Split out of #5974; its benchmark comment below compares against master.