Repository navigation
Conversation
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 58s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composite items rendered through
useCompositeItem(Tabs, Toolbar, Radio Group, toggle groups, Navigation Menu, and the menubar's Menu triggers) learned their index only after mount, so every item rendered twice. They now guess it from render order withuseCompositeListItem's existingguessoption, as Menu and Combobox items already do; a wrong guess, for grouped or out-of-order items, is corrected in the commit before paint.The smoke comment below doesn't list it: no difference is confidently past its 10% band. Locally against master, the smoke cases of the components it touches (30 rounds, 99% intervals):
Split out of #5974.