Repository navigation
[scheduler] Memoize the time grid columns, so the grid's own updates don't re-render every event - #24179
Draft
Janpot wants to merge 1 commit into
Draft
[scheduler] Memoize the time grid columns, so the grid's own updates don't re-render every event#24179Janpot wants to merge 1 commit into
Janpot wants to merge 1 commit into
Conversation
…don't re-render every event
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
added
performance
type: enhancement
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right after mount,
DayTimeGridsetshasScrollfrom a layout effect, which re-renders the grid. ItsTimeGridColumns weren't memoized, so that second commit re-rendered every event of every column. Their props are primitives and a memoizedday, soReact.memoskips them.Measured with the smoke benchmark of #24028 (EventCalendar week view with 200 events, 30 rounds, 99% intervals):
render−27% to −32%,bench:paint−18% to −25%; the post-mount update went from 17.4 ms to 1.4 ms. I'll rebase onto #24028 once it's merged, so the benchmark comment shows it.