Rename handlers and events for entity processing consistency #3925
+51
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a warning/error to addEventHandler whenever somebody tries to register a handler for |
botder
added
refactor
backwards-incompatible
I'll find a way to do it |
|
This event should be named "onClientPostUpdate". It will describe the meaning of the event better. |
… update related references
botder
reviewed
Jan 8, 2025
Comment on lines
3879
to
3883
| if (m_pRootEntity->CallEvent("onClientPedsProcessed", Arguments, false)) | ||
| { | ||
| throw std::runtime_error("'onClientPedsProcessed' is no longer supported, renamed to 'onClientPostUpdate'"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The better solution would be to just assume onClientPostUpdate when somebody does addEventHandler("onClientPedsProcessed", ...) but also show a warning.
botder
reviewed
Jan 9, 2025
Comment on lines
3879
to
3883
| if (m_pRootEntity->CallEvent("onClientPedsProcessed", Arguments, false)) | ||
| { | ||
| CStaticFunctionDefinitions::AddEventHandler("onClientPedsProcessed", "onClientPostUpdate", "The 'onClientPedsProcessed' event is deprecated and has been renamed to 'onClientPostUpdate'."); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I don't know how you came up with the idea to put that here, remove it and adapt CStaticFunctionDefinitions::AddEventHandler.
- Move deprecation handling from event trigger to AddEventHandler - Remove broken compatibility code from PostWorldProcessEntitiesAfterPreRenderHandler - Add proper warning when scripts use deprecated event name - Ensure seamless migration: old event name redirects to onClientPostUpdate
Fix backward compatibility for onClientPedsProcessed event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from
onClientPedsProcessedtoonClientEntitiesProcessedindicates that the event is not only related to pedestrians, but can also be used on various elements, for example: #3922 The idea to revive the event came from this issue.The ped manipulators have also been renamed to entities.