Repository navigation
Conversation
Contributor
|
We need to make it more visible (currently ruminating on exactly how), but if you don't want the app's volume controls to affect the whole system, you can select 'Software Volume' from within the app's settings (menubar -> settings -> software volume). |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on Linux (PulseAudio) where changing the volume inside the desktop app affected the entire system/device volume rather than just the specific application's audio stream.
Changes Made
Target Sink-Inputs: Refactored the Linux PulseAudio volume control implementation (src/sendspin/volume_control/linux.rs) to target sink-inputs instead of global audio device sinks.
Process ID (PID) Matching: Implemented stream introspection to automatically locate and bind to the specific PulseAudio stream matching the application's process ID (application.process.id).
Async Command Handling & Lints: Cleaned up channel communication for asynchronous PulseAudio callbacks and resolved Clippy/type warnings.
Related Issue
Related to #188
Did not touch the windows side of things because i dont have a device to test it on.