sidecar: disable networking if no network dependencies are present #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer version of Compose used with Mutagen Compose v0.18.0 doesn't like an empty network map and tries to connect the sidecar container to a network with an empty name if there are no networks present in the service configuration. To fix this, we'll disable networking for the sidecar if not needed. Signed-off-by: Jacob Howard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do and why is it needed?
The newer version of Compose used with Mutagen Compose v0.18.0 doesn't like an empty network map and tries to connect the sidecar container to a network with an empty name if there are no networks present in the service configuration.
To fix this, we'll disable networking for the sidecar if not needed.
Which issue(s) does this pull request address (if any)?
Fixes #81
Any other notes for the review process?
Needs backport to v0.18.x