Update _table.scss so sort-icon spans don't change width#99
Open
mghoffmann-regions wants to merge 1 commit intomuziehdesign:developfrom
Open
Update _table.scss so sort-icon spans don't change width#99mghoffmann-regions wants to merge 1 commit intomuziehdesign:developfrom
mghoffmann-regions wants to merge 1 commit intomuziehdesign:developfrom
Conversation
The `mzSortKey` directive adds spans classed sort-icon for up/down arrows to table column headers to indicate sorting. These spans change the width of the column headers if the .sort-ascending and .sort-descending selectors apply, causing the table to resize whenever a different sort column is changed. This should keep sortable headers the same size even when the sort arrows are not rendered in them. Signed-off-by: mghoffmann-regions <michael.hoffmann2@regions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mzSortKeydirective adds spans classed assort-iconto table column headers, for up/down arrows to indicate sorting.These spans change the width of the column headers if the
.sort-ascendingand.sort-descendingselectors apply, causing the table to resize whenever a different sort column is changed.This should keep sortable headers the same size even when the sort arrows are not rendered in them.