merge queue: checking main (f5a4795), #3441 and #3430 together#3474
Closed
mergify[bot] wants to merge 4 commits into
Closed
merge queue: checking main (f5a4795), #3441 and #3430 together#3474mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
The sync profiler defaulted page size to 100 and only read a pagination limit param's default, never its maximum. APIs that cap page_size below 100 (e.g. Granola public API: maximum 30 on /v1/notes and /v1/folders) then get every sync page rejected with HTTP 400. Capture the maximum on spec.Param and clamp the resolved page size down to it. - Normalize both OpenAPI encodings of an upper bound at parse time: inclusive maximum -> Param.Maximum; exclusive (3.1 numeric exclusiveMaximum, or 3.0 maximum + exclusiveMaximum: true) -> Param.ExclusiveMaximum. In 3.1 both are independent assertions and may co-exist; the profiler takes the most restrictive, yielding floor(inclusive) or ceil(exclusive)-1. - Apply the clamp on both sync paths: the cursor/page path (syncPaginationDefaultsFromEndpoint) and the ID-walk path (detectIDWalkParams), which resolves its page size independently. Fixes #3440
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (f5a4795), #3441 and #3430 are queued together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #3430.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success = build-and-testcheck-success = generated-testcheck-success = go-lintcheck-success = goldencheck-success = testgithub-review-approved[🛡 GitHub branch protection]require-ready-label-and-ci]:#changes-requested-reviews-by = 0#review-threads-unresolved = 0check-success = build-and-testcheck-success = generated-testcheck-success = go-lintcheck-success = goldencheck-success = pr-titlecheck-success = testlabel = ready-to-mergehead = release-please--branches--maintitle ~= ^chore\(main\): release-files ~= ^(\.github/workflows/|\.github/scripts/|scripts/|\.github/CODEOWNERS$)approved-reviews-by = mvanhornapproved-reviews-by = tmchowauthor = mvanhornauthor = tmchowlabel = queuedcheck-neutral = Greptile Reviewcheck-skipped = Greptile Reviewcheck-success = Greptile Reviewhead ~= ^mergify/merge-queue/head = release-please--branches--maintitle ~= ^chore\(main\): releasecheck-neutral = Mergify Merge Protectionscheck-skipped = Mergify Merge Protectionscheck-success = Mergify Merge ProtectionsRequired conditions to stay in the queue:
#changes-requested-reviews-by = 0#review-threads-unresolved = 0-draftbase = maincheck-success = build-and-testcheck-success = generated-testcheck-success = go-lintcheck-success = goldencheck-success = pr-titlecheck-success = testgithub-review-approved[🛡 GitHub branch protection]require-ready-label-and-ci]:#changes-requested-reviews-by = 0#review-threads-unresolved = 0check-success = build-and-testcheck-success = generated-testcheck-success = go-lintcheck-success = goldencheck-success = pr-titlecheck-success = testlabel = ready-to-mergehead = release-please--branches--maintitle ~= ^chore\(main\): release-files ~= ^(\.github/workflows/|\.github/scripts/|scripts/|\.github/CODEOWNERS$)approved-reviews-by = mvanhornapproved-reviews-by = tmchowauthor = mvanhornauthor = tmchowcheck-success = Greptile Reviewlabel = queuedcheck-neutral = Greptile Reviewcheck-skipped = Greptile Reviewhead ~= ^mergify/merge-queue/head = release-please--branches--maintitle ~= ^chore\(main\): release-files ~= ^(\.github/workflows/|\.github/scripts/|scripts/|\.github/CODEOWNERS$)approved-reviews-by = mvanhornapproved-reviews-by = tmchowauthor = mvanhornauthor = tmchowcheck-success = Greptile Reviewcheck-neutral = Greptile Reviewcheck-skipped = Greptile Reviewhead = release-please--branches--maintitle ~= ^chore\(main\): releasecheck-success = Mergify Merge Protectionscheck-neutral = Mergify Merge Protectionscheck-skipped = Mergify Merge Protections