Include: preliminary FilesystemIncludeProvider #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwkmwkmwk
reviewed
Sep 25, 2021
vfront_verilog_parser/src/include.rs
Outdated
| let filename = Path::new(name); | ||
| if filename.is_absolute() { | ||
| if mode == IncludeSearchMode::System { | ||
| todo!("forbid use of absulute paths in system include directives, per Section 22.4 of IEEE 1800-2017"); |
mwkmwkmwk
reviewed
Sep 25, 2021
|
|
||
| #[test] | ||
| fn test_filesystem_include_provider() { | ||
| // TODO: this is testing using some existing workspace files rather than designated |
There was a problem hiding this comment.
yes, don't do this — instead, add the tempfile crate to dev-dependencies, use it to create and fill out a temp dir (or several)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.