Skip to content

[ISSUE #4861]♻️Refactor send_batch_to_queue_with_callback to accept generic message types implementing MessageTrait #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxsm merged 1 commit into from
Dec 26, 2025
+9 −6
Merged

[ISSUE #4861]♻️Refactor send_batch_to_queue_with_callback to accept generic message types implementing MessageTrait #5004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rocketmq-client/src/producer/default_mq_producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,13 +1137,14 @@ impl MQProducer for DefaultMQProducer {
Ok(())
}

async fn send_batch_to_queue_with_callback<F>(
async fn send_batch_to_queue_with_callback<M, F>(
&mut self,
msgs: Vec<Message>,
msgs: Vec<M>,
mq: MessageQueue,
f: F,
) -> rocketmq_error::RocketMQResult<()>
where
M: MessageTrait + Send + Sync,
F: Fn(Option<&SendResult>, Option<&dyn std::error::Error>) + Send + Sync + 'static,
{
let batch = self.batch(msgs)?;
Expand Down
5 changes: 3 additions & 2 deletions rocketmq-client/src/producer/mq_producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,13 +586,14 @@ pub trait MQProducer {
/// # Returns
///
/// * `rocketmq_error::RocketMQResult<()>` - An empty result indicating success or failure.
async fn send_batch_to_queue_with_callback<F>(
async fn send_batch_to_queue_with_callback<M, F>(
&mut self,
msgs: Vec<Message>,
msgs: Vec<M>,
mq: MessageQueue,
f: F,
) -> rocketmq_error::RocketMQResult<()>
where
M: MessageTrait + Send + Sync,
F: Fn(Option<&SendResult>, Option<&dyn std::error::Error>) + Send + Sync + 'static;

/// Sends a batch of messages to a specific message queue with a callback and a timeout.
Expand Down
5 changes: 3 additions & 2 deletions rocketmq-client/src/producer/transaction_mq_producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,13 +420,14 @@ impl MQProducer for TransactionMQProducer {
.await
}

async fn send_batch_to_queue_with_callback<F>(
async fn send_batch_to_queue_with_callback<M, F>(
&mut self,
msgs: Vec<Message>,
msgs: Vec<M>,
mq: MessageQueue,
f: F,
) -> rocketmq_error::RocketMQResult<()>
where
M: MessageTrait + Send + Sync,
F: Fn(Option<&SendResult>, Option<&dyn std::error::Error>) + Send + Sync + 'static,
{
self.default_producer
Expand Down