-
Notifications
You must be signed in to change notification settings - Fork 218
[ISSUE #5533]✨Enhance logging in ClientRequestProcessor by adding debug level for request code #5546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… debug level for request code
|
🔊@WaterWhisperer 🚀Thanks for your contribution🎉! 💡CodeRabbit(AI) will review your code first🔥! Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
WalkthroughThe change modifies logging verbosity in the ClientRequestProcessor by downgrading the request code logging statement from info to debug level, reducing noise in standard logs while retaining detailed information for debug-level output. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @rocketmq-namesrv/src/processor/client_request_processor.rs:
- Around line 57-60: The per-request log in ClientRequestProcessor was lowered
from info! to debug!, but DefaultRequestProcessor still logs at info!, so update
the equivalent log call in DefaultRequestProcessor to use debug! as well (locate
the Info log in the DefaultRequestProcessor implementation—e.g., inside the
request handling method where it prints "Name server DefaultRequestProcessor
Received request code: {:?}") and change info! to debug! so both processors use
the same logging level and message pattern for per-request events.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
rocketmq-namesrv/src/processor/client_request_processor.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Code Coverage
- GitHub Check: Build & Test (windows-latest)
- GitHub Check: Build & Test (ubuntu-latest)
- GitHub Check: Build & Test (macos-latest)
- GitHub Check: auto-approve
🔇 Additional comments (1)
rocketmq-namesrv/src/processor/client_request_processor.rs (1)
31-31: LGTM: Import correctly updated to support debug logging.The import change from
tracing::infototracing::debugis correct and aligns with the updated log statement at line 57.
|
@WaterWhisperer I think you could take on some more challenging issues, with difficulty levels ranging from medium to hard, or share some of your own ideas and optimizations for the project.Improving one's own abilities in this way would be better |
mxsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5546 +/- ##
=======================================
Coverage 38.43% 38.43%
=======================================
Files 815 815
Lines 110551 110551
=======================================
Hits 42492 42492
Misses 68059 68059 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mxsm Thanks, I always wanted to try harder issues, and they were claimed when I saw them before |
Which Issue(s) This PR Fixes(Closes)
Fixes #5533
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.