List with fixed Item Size #292
Merged
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,9 +9,13 @@ import { ConfigurableFactory, DefaultAppearance, Rect2, RenderContext, Shape, Sh | |||
| import { CommonTheme } from './_theme'; | |||
|
|
|||
| const ACCENT_COLOR = 'ACCENT_COLOR'; | |||
| const ITEM_SIZE_FIXED = 'ITEM_SIZE_FIXED'; | |||
| const FIXED_ITEM_GAP = 'FIXED_ITEM_GAP'; | |||
There was a problem hiding this comment.
Can we use the naming to group them a little bit? Like ITEMS_FIXED_GAP or so?
|
Btw: do you squash commit? Or should I care about the commit history? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the items of the
listshape are always scaled to the size of the list. This PR adds the option to switch to a fixed item size.