feat: Optionally dump full stack traces #56
Conversation
See Readme for details
- Use `var` rather than `const` to support node 0.10.0 to < 4.0.0 - Update test-all to exit early and re-run the failing test - Fix try-catch in kitchensink to be valid on node 0.10.0
|
Note that the formatting of code location in the stack traces makes IDEs like webstorm recognize them and make them clickable :) |
There was a problem hiding this comment.
I double-checked the PR against the various node versions I support, seems mostly good to go. I made a branch with some of the changes (and a couple other fixes for the tests); you should be able to cherry-pick the commit from here https://github.com/myndzi/wtfnode/compare/myndzi/feat/full-stacktraces-tweaks
If it's not too much trouble, would you mind addressing the indentation comment?
- Use `var` rather than `const` to support node 0.10.0 to < 4.0.0 - Update test-all to exit early and re-run the failing test - Fix try-catch in kitchensink to be valid on node 0.10.0
Also put all the rendering code in one place
|
Indenting should be fixed now, kitchensink output looks good to me @myndzi :) |
|
Thanks so much for your contribution! I'll publish a new version shortly |
|
(I missed one thing when --fullstack isn't present, the printed output format names don't line up with the arguments in Timers/Intervals. |
|
Published. It seems to have just been deleting the |
See Readme for details
This implements #55