[N/land] Pass category updates to/from Alloy #376
Merged
+267
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nephila-nacrea
changed the base branch from
master
to
nland-assigned-to-extra-details
dracos
requested changes
Dec 6, 2024
There was a problem hiding this comment.
My concern here is we've just cut down the API calls used, and this adds two per update, so I'd be worried of hitting the rate limit. I think we can change the fetch_updated_resources call to have a join to the category/group so that we get that information as part of the original call, which I think we should look into doing here.
The code itself looks good :)
dracos
force-pushed
the
nland-assigned-to-extra-details
branch
from
305a485 to
4eb28e7
Compare
dracos
force-pushed
the
nland-alloy-pass-category
branch
from
8ec4478 to
d5d3c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mysociety/societyworks/issues/4648.