event-target: make AddOptions type compatible with recent TS#46
Open
peat-psuwit wants to merge 1 commit into
Open
event-target: make AddOptions type compatible with recent TS#46peat-psuwit wants to merge 1 commit into
peat-psuwit wants to merge 1 commit into
Conversation
Recent update in TS add `signal` property to `AddOptions` interface [1].
Over there, the definition is:
signal?: AbortSignal;
You'll notice that `null` is not in the definition. This causes the
whole EventTarget type to be incompatible with TS one.
To fix this incompatibility, just remove `null` from the field's union.
[1] https://github.com/microsoft/TypeScript/blob/feac9eb126e56837d16acb61cd019ce8520db76c/src/lib/dom.generated.d.ts#L8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent update in TS add
signalproperty toAddOptionsinterface [1].Over there, the definition is:
You'll notice that
nullis not in the definition. This causes thewhole EventTarget type to be incompatible with TS one.
To fix this incompatibility, just remove
nullfrom the field's union.[1] https://github.com/microsoft/TypeScript/blob/feac9eb126e56837d16acb61cd019ce8520db76c/src/lib/dom.generated.d.ts#L8