[#142] select query 테스트코드 작성 및 리팩토링 #143
Conversation
Pull reviewers statsStats of the last 14 days for rrdb:
|
|
✅ Total Coverage: 47.46% |
myyrakle
force-pushed
the
test/#142
branch
2 times, most recently
from
1e152e2 to
2f5969c
Compare
|
✅ Total Coverage: 47.15% |
|
✅ Total Coverage: 47.15% |
|
✅ Total Coverage: 47.35% |
|
✅ Total Coverage: 47.35% |
|
✅ Total Coverage: 47.38% |
|
✅ Total Coverage: 47.84% |
|
✅ Total Coverage: 47.86% |
|
✅ Total Coverage: 47.96% |
|
✅ Total Coverage: 48.05% |
|
✅ Total Coverage: 48.07% |
|
✅ Total Coverage: 48.10% |
|
✅ Total Coverage: 48.20% |
|
✅ Total Coverage: 48.23% |
|
✅ Total Coverage: 48.25% |
|
✅ Total Coverage: 48.48% |
|
✅ Total Coverage: 48.57% |
myyrakle
changed the title
| @@ -45,7 +45,7 @@ jobs: | |||
|
|
|||
| - name: Set coverage env variable | |||
| run: | | |||
| echo "COVERAGE=$(cat coverage_total_percent.txt)" >> $GITHUB_ENV | |||
| echo "COVERAGE=$(head -n 1 coverage_total_percent.txt)" >> $GITHUB_ENV | |||
| self.unget_next_token(current_token); | ||
| // 현재 select_item은 종료된 것으로 판단. | ||
| Ok(select_item.build()) | ||
| } |
There was a problem hiding this comment.
이거 추가하죠
1. 잘못된 토큰 시퀀스
- 불완전한 문장 끝
SELECT 1 FROMSELECT * FROM foo.(테이블 이름이 끝나지 않음)
- 중복된 키워드
SELECT SELECT 1 FROM fooFROM foo FROM bar
2. 누락된 필수 키워드 및 구문
- 누락된 FROM 절
SELECT 1
- WHERE 절의 누락
SELECT 1 WHERESELECT 1 FROM foo WHERE
3. 잘못된 토큰 타입
- 숫자가 아닌 인덱스
SELECT * FROM foo OFFSET 'test'
- 비정상적인 문자
SELECT * FROM foo WHERE id = @
4. 유효하지 않은 토큰 조합
- 잘못된 연산자 사용
SELECT 1 WHERE 1 =SELECT * FROM foo WHERE id = != 1
- GROUP BY와 호환되지 않는 집계 함수
SELECT COUNT(id), name FROM foo GROUP BY idSELECT COUNT(id), name FROM foo GROUP BY name
5. 하위 쿼리의 비정상적 구성
- 누락된 하위 쿼리 키워드
SELECT 1 FROM (SELECT 1)
- 하위 쿼리의 잘못된 사용
SELECT (SELECT 1 FROM foo)
6. 잘못된 GROUP BY, HAVING, ORDER BY 항목
- GROUP BY 항목 제한
SELECT COUNT(id), name FROM foo GROUP BY id
- HAVING 절의 잘못된 조건
SELECT COUNT(id) FROM foo HAVINGSELECT COUNT(id) FROM foo HAVING COUNT(id)
- ORDER BY 항목 제한
SELECT * FROM foo ORDER BY
7. 여러 SQL 문장
- 비정상적인 두 SQL 문장 연결
SELECT * FROM foo; SELECT * FROMSELECT *; SELECT * FROM
8. 잘못된 함수 호출
- 인자로 함수를 받는 경우
SELECT COUNT FROM fooSELECT COUNT(* FROM foo)
9. 잘못된 JOIN 사용
- JOIN의 잘못된 사용
SELECT * FROM foo LEFT JOINSELECT * FROM foo JOIN bar ON
resolves: #142
설명
테스트 코드 작성
