Skip to content

fix!: make net_protocol feature work without rpc #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

dignifiedquire
Copy link
Collaborator

also removes rpc from the default feature flags to reduce dependency load

also removes `rpc` from the default feature flags to reduce dependency load
Copy link

github-actions bot commented Dec 4, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/27/docs/iroh_blobs/

Last updated: 2024-12-04T13:10:11Z

Co-authored-by: Philipp Krüger <[email protected]>
@rklaehn
Copy link
Collaborator

rklaehn commented Dec 4, 2024

Not sure I like rpc not being on by default. The standard way to use blobs should be via the (mem or quic) rpc client, which of course requires rpc.

But we can switch it back on later I guess.

    "dep:quic-rpc",
    "dep:quic-rpc-derive",
    "dep:nested_enum_utils",
    "dep:strum",
    "dep:futures-util",
    "dep:ref-cast", // ?
    "dep:portable-atomic", // ?
    "dep:walkdir", // this one we might get rid of
    "downloader",

@dignifiedquire dignifiedquire merged commit 4c1446f into main Dec 4, 2024
24 checks passed
@dignifiedquire dignifiedquire deleted the fix-feature-flags branch December 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants