Skip to content

[WIP]: rework net_report #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 27 commits into
base: refactor-transports
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b654ebf
watch report, part 1
dignifiedquire May 15, 2025
37d21cd
refactor: drop STUN, ICMP & Hairpin probes
dignifiedquire May 16, 2025
ec72f3a
refactor: collect probe results and generate report at the end
dignifiedquire May 16, 2025
dc1af31
fixup
dignifiedquire May 16, 2025
ad6aa1d
refactor: simplify latency storage
dignifiedquire May 19, 2025
7077e56
refactor: remove duplicate type NetInfo
dignifiedquire May 19, 2025
7d7cd68
wasm fixes
dignifiedquire May 19, 2025
b5671ef
refactor: simplify report finalization
dignifiedquire May 19, 2025
d6bd139
refactor: build report in net_report
dignifiedquire May 19, 2025
45a57b6
fix blocking issues
dignifiedquire May 19, 2025
d42bfc7
refactor: more net_report cleanup
dignifiedquire May 19, 2025
511c7fc
refactor: quic -> qad
dignifiedquire May 19, 2025
cf43c37
wip
dignifiedquire May 20, 2025
d213dcb
cleanup
dignifiedquire May 22, 2025
d76e4b1
simplify net_run scheduling further
dignifiedquire May 22, 2025
63dc72a
fix browser compiles
dignifiedquire May 22, 2025
dd9bde8
reportgen: use cancellation tokens
dignifiedquire May 22, 2025
371a650
cleanup net_report scheduling some more
dignifiedquire May 23, 2025
0fddf40
refactor: avoid double expensive interface retrieval
dignifiedquire May 23, 2025
510ee3e
refactor: avoid locking for pending call me maybes
dignifiedquire May 23, 2025
b96c01f
fixup docs
dignifiedquire May 23, 2025
39160e8
refactor: remove me field from magicsock
dignifiedquire May 23, 2025
3a5ac31
refactor: magicsock: only store the public key
dignifiedquire May 23, 2025
a24045a
refactor: extract disco state into its own struct
dignifiedquire May 23, 2025
0a87e6c
refactor: magicsock: more simplifications
dignifiedquire May 23, 2025
614e22d
refactor: magicsock: send disco messages from actor
dignifiedquire May 23, 2025
0bf2787
refactor: magicsock streamline disco functions
dignifiedquire May 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ unused-async = "warn"
iroh-quinn = { git = "https://github.com/n0-computer/quinn", branch = "matheus23/mut-self" }
iroh-quinn-udp = { git = "https://github.com/n0-computer/quinn", branch = "matheus23/mut-self" }
iroh-quinn-proto = { git = "https://github.com/n0-computer/quinn", branch = "matheus23/mut-self" }
netwatch = { git = "https://github.com/n0-computer/net-tools", branch = "feat-new-udp-api"}
netwatch = { git = "https://github.com/n0-computer/net-tools", branch = "feat-interfaces"}
4 changes: 2 additions & 2 deletions iroh/src/endpoint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ impl Endpoint {
/// # });
/// ```
#[doc(hidden)]
pub fn net_report(&self) -> n0_watcher::Direct<Option<Arc<Report>>> {
pub fn net_report(&self) -> impl Watcher<Value = Option<Report>> {
self.msock.net_report()
}

Expand Down Expand Up @@ -3166,7 +3166,7 @@ mod tests {
.await?;

// can get a first report
endpoint.net_report().initialized().await?;
endpoint.net_report().updated().await?;

Ok(())
}
Expand Down
Loading
Loading