feat: Make fmt_short return an impl Display so we can avoid an allocation. #3460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3460/docs/iroh/ Last updated: 2025-09-22T09:28:03Z |
flub
reviewed
Sep 19, 2025
iroh-base/src/key.rs
Outdated
| pub const LENGTH: usize = ed25519_dalek::PUBLIC_KEY_LENGTH; | ||
| } | ||
|
|
||
| struct PublicKeyShort(PublicKey); |
There was a problem hiding this comment.
The old code used space for 10 bytes on the heap. This version uses 32 bytes on the stack?
I think it's a great idea to try and get rid of the heap allocation. But maybe you can give PublicKeyShort only the 5 bytes needed for the display?
There was a problem hiding this comment.
Yes, you could do that easily. PublicKeyShort is not part of the public API, so you can optimize it.
flub
approved these changes
Sep 22, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, fmt_short allocates a String. It is used quite a few times in trace! statements. This makes it not allocate.
Not sure if it is worth it.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme