feat(irpc-iroh): make it easy to do a manual connection loop with authentication #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
Frando/manual-accept-with-auth
branch
2 times, most recently
from
35b6d34 to
fec1283
Compare
Frando
force-pushed
the
Frando/manual-accept-with-auth
branch
from
fec1283 to
45911f2
Compare
Frando
force-pushed
the
Frando/manual-accept-with-auth
branch
from
541b450 to
4e13805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes a function
read_requestfromirpc_irohthat can be used to read a single request from a connection, and upcast the streams into the types used by irpc.With this new public function, it is easy to drive the connection loop yourself, which you might want to do if there's some state that changes, e.g. that the first request is expected to be an authentication requests, and all other requests should be declined if that is not the case.
The change is semver-compatible (only adds a new public fn).
See
examples/auth.rsfor an example.This is used in https://github.com/n0-computer/n0des/pull/259