feat(quinn): Refactor polling & sending to take &mut self
#67
Conversation
matheus23
changed the title
poll_send-based AsyncUdpSocket abstraction&mut self
matheus23
force-pushed
the
matheus23/mut-self
branch
from
871e5c6 to
54043ca
Compare
There was a problem hiding this comment.
Overall seems fine, but needs a lot of docs updates.
One main concern is that I'd like to be relatively sure that this isn't creating a performance impact on upstream Quinn. I believe @matheus23 has been working on this already.
The other is what upstream mentioned: this is a breaking change. For us this would be 0.14. I'd also prefer if we managed to move this upstream. I understand they also have concerns about the semvers-incompatible change. We should already start a PR and have it go through review to a "basically accepted" state, at which point I guess it'd be waiting for when they make the next semver-incompatible release. I believe there are already a few such issues queued up, so this will probably happen at some point.
No description provided.