Improve internal benchmarks#125
Merged
Merged
Conversation
… too baked in to change right now
By converting the benchmark option setting from a argv to a real option, we make room to have a more consistent set of test filter strings. By creating an new string to id mapping type, we should in the future be able to simplify some of the other config file parsing types.
The pdu2tun test still has some undiagnosed memory corruption when using the new process and so it is not converted over.
The PEEK and POKE pthread actions are intended for debugging, and this code was using them for inter-process communication. This mismatch could lead to memory corruption (and I suspect this was the reason why the pdu2tun test could not be converted to use the simpler malloc process) Replace with a block of shared memory and a defined format and access pattern.
By running the alarm action inside the child, the child becomes self contained. If the parent dies or fails to trace correctly, the child will manage its own exit. This also constrains the information from to just getting data out of the child, not sending data into the child.
…port the pdu2tun test
With this, it is now possible to benchmark both TX and RX in either direction. Co-Authored-By: Hamish Coleman <hamish@zot.org>
Co-Authored-By: Hamish Coleman <hamish@zot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.