fix(edge_utils): update memcpy to use n3n_sock_t for destination#127
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 48.87% 48.86% -0.01%
==========================================
Files 54 54
Lines 10570 10570
==========================================
- Hits 5166 5165 -1
- Misses 5404 5405 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing IPv6 addresses, using the smaller
sizeof(struct sockaddr_in)causes the last 4 bytes of data to be truncated or retain old values.This fix ensures the complete
n3n_sock_tstructure is copied correctly, resolving the IPv6 address truncation issue, which is mentioned in #21 (comment).✅ I have already tested this change, it works properly.