Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation docs & add SEO header for the MD file #57

Merged
merged 26 commits into from
Jul 6, 2019

Conversation

Ross0101
Copy link
Contributor

@Ross0101 Ross0101 commented Jul 6, 2019

What is the purpose of the change

#11 #4
Translation of the article is as follows:

  • faq.md
  • nacos-config-benchmark.md
  • nacos-sync-use.md
  • namespace-endpoint-best-practices.md

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Test your code locally by running docsite start, and make sure it works as expected.
  • Make sure no files under build directory is added.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Ross0101 Ross0101 changed the title Translation docs Translation docs & add SEO header for the MD file Jul 6, 2019
@caojiele
Copy link
Collaborator

caojiele commented Jul 6, 2019

LGTM

@caojiele caojiele merged commit f48810e into nacos-group:master Jul 6, 2019
@caojiele caojiele self-requested a review July 12, 2019 02:24
@caojiele caojiele removed their request for review July 12, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants