Fix category description and compatibility pin - #15
Conversation
|
Why don't you leave the old entry in the compatibility file? Of course there shouldn't be any sites using a that old version, but better safe than sorry. |
@moin-Jana I was recommended by RGJ to use this version, as it may not be compatible with stable. As a result, the commit hash here will use the version before my initial PR, i.e. using the widget system. Should I have left it there so there are 2 pins in that file? My dev install runs 3.5.0beta-8, and it works there. |
|
Maybe I still haven't fully understood how pinning works. But I thought the current pin say Discourse installs with a version below 3.4.999 will receive the old version of the theme and since stable is below that that works for stable. But what about a forum on 3.5.0.beta1 that isn't a version below your pin, does the component work there? Based on my understanding I would have used <3.5.0.beta8 if that is the version where you know it works. Wouldn't that pin forums on stable and older beta releases to the commit from last year? And since the file can have multiple entries I wouldn't remove the old one, but simply add the new one: |
2 participants
With this PR,
htmlSafeis applied on category descriptions, so HTML in category descriptions will show up (link).Additionally, a compatibility pin is added to use the version of this TC to before the recent compatibility issues fix was merged, for forums running on stable before 3.5.0.