switch to Project file #44
Conversation
test/freqtable.jl
Outdated
| @@ -168,7 +168,7 @@ for docat in [false, true] | |||
| @test tab == [2 0 | |||
| 0 5 | |||
| 1 6] | |||
| @test names(tab[1:2, :]) == [["Iris-setosa", "Iris-versicolor"], [false, true]] | |||
| # @test names(tab[1:2, :]) == [["Iris-setosa", "Iris-versicolor"], [false, true]] | |||
There was a problem hiding this comment.
This only errors for docat == true (see for loop above). It's an unrelated method error, not sure where it comes from, but I suspect it has something to do with CategoricalArrays.
There was a problem hiding this comment.
Good catch. It also happens on master so that's not a blocker for this PR -- let's keep this change out for now.
Here's a reproducer:
using NamedArrays, CategoricalArrays
NamedArray(ones(3, 2), (["a", "b", "c"], Vector(categorical([true, false]))), ("A", "B"))[1:2,:]This is a corner case which happens when passing a Vector{<:CategoricalValue}, which gets converted to a CategoricalVector on indexing, which apparently isn't supported by NamedArrays. This only happens when crossing categorical and non categorical variables. The code should unwrap the values.
Filed #45.
|
It also seems that Tables.jl requires julia 1.0 compatibility. Is it OK to drop julia 0.7 compatibility here? |
|
Yes I think it's fine to require Julia 1.0. |
|
Tests are failing everywhere with the right error, so merging. :-) |
I've put the (previously unspecified) Tables dependency directly to 1.0 (I need it to have StatsMakie compatibility with Tables 1.0).
The only thing I don't understand is a
NamedArraymethod error in one of the tests. I've commented it out for the moment.