Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 500 diagonal scroll trackpad #873

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Billgonzo123
Copy link

@Billgonzo123 Billgonzo123 commented Sep 27, 2022

Issue Number: 500

Link to issue

I restored the code from v0.21.0 and it has restored the functionality of touch pad diagonal scrolling. It does seem that on most browser you must initially move your fingers in a diagonal motion because scrolling seems to be locked to the initial direction of scrolling per event.

I have added a small bit of code so that when clicking inside the calendar component it can be dragged on the X and Y axis. To do this I turned dragStartPosition into an object containing x and y scroll values. I then use dragStartPosition.y to update the windows scroll position.

I also fixed a bug with the shiftKey modifier when scrolling. deltaY was prioritized in a ternary resulting in glitchy and confusing movement when touchpad scrolling was diagonal. deltaX is now prioritized.

@Billgonzo123
Copy link
Author

Billgonzo123 commented Sep 27, 2022

The traditionalScroll prop mentioned in the issue seems to be undefined

@Billgonzo123 Billgonzo123 marked this pull request as draft September 27, 2022 19:37
@Billgonzo123
Copy link
Author

oops, this was supposed to be a draft!

@Billgonzo123 Billgonzo123 marked this pull request as ready for review September 27, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant