Skip to content

Refactor ActionCable.connect function and upgrade websocket and dart SDK#24

Merged
namiwang merged 4 commits into
namiwang:masterfrom
Dreamersoul:1.2.1
Oct 25, 2024
Merged

Refactor ActionCable.connect function and upgrade websocket and dart SDK#24
namiwang merged 4 commits into
namiwang:masterfrom
Dreamersoul:1.2.1

Conversation

@Dreamersoul
Copy link
Copy Markdown
Collaborator

  • Refactored the ActionCable.connect function to improve readability and leverage Dart's null safety.
  • Updated the websocket dependency to the latest version.

BREAKING CHANGE:

  • Changed the connect function from ActionCable.Connect to ActionCable.connect.

Closes #13

- Refactored the ActionCable.connect function to improve readability and leverage Dart's null safety.
- Updated the websocket dependency to the latest version.

BREAKING CHANGE:
- Changed the connect function from `ActionCable.Connect` to `ActionCable.connect`.

Closes namiwang#13
@Dreamersoul Dreamersoul changed the title Refactor ActionCable.connect function and update dependencies Refactor ActionCable.connect function and upgrade websocket and dart SDK Oct 21, 2024
@Dreamersoul
Copy link
Copy Markdown
Collaborator Author

Dreamersoul commented Oct 21, 2024

Consolidated changes from #18 and #15

@namiwang
Copy link
Copy Markdown
Owner

@Dreamersoul Thanks for the work on this! Let me pub a new version

@namiwang namiwang merged commit 4fcda3e into namiwang:master Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants