Replace generic_fillattr with vfs_getattr in SMB1 specific code #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 22, 2024 01:02
Use vfs_getattr instead of generic_fillattr in order to call the fs-specific ->getattr if it exists. vfs_getattr can return an error, so adapt functions to return the error to the caller. This fixes incorrectly filled AllocationSize field in SMB responses for files on XFS-backed shares. Signed-off-by: Marios Makassikis <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
…tion_info Use vfs_getattr() as inode->i_blocks may be 0 on some filesystems (XFS for example). Signed-off-by: Marios Makassikis <[email protected]> Signed-off-by: Namjae Jeon <[email protected]>
path_put() is called twice on the same path in smb_setattr Fixes: d60c3c8 ("ksmbd: smb1: convert ksmbd_vfs_kern_path to ksmbd_vfs_kern_path_locked") Signed-off-by: Marios Makassikis <[email protected]>
generic_fillattr should only be used by filesystems in their ->getattr implementation. Signed-off-by: Marios Makassikis <[email protected]>
Signed-off-by: Marios Makassikis <[email protected]>
|
As discussed in #474 |
|
Applied. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.