Skip to content

Conversation

SikiFn
Copy link
Contributor

@SikiFn SikiFn commented Apr 9, 2015

The script no more relies on *nix "cp" command.
Native PHP copy support has been added.
Therefore, the script can be used on windows now also.

The script no more relies on *nix "cp" command.
Native PHP copy support has been added.
Therefore, the script can be used on windows now also.
@Wayn0
Copy link

Wayn0 commented Apr 9, 2015

could probably make it windows friendly.
using DIRECTORY_SEPARATOR instead of '/' or
define('DS', DIRECTORY_SEPARATOR);

then DS instead of '/'

@SikiFn
Copy link
Contributor Author

SikiFn commented Apr 9, 2015

This code works great in windows though :)
On Apr 9, 2015 4:37 PM, "Wayne Oliver" [email protected] wrote:

could probably make it windows friendly.
using DIRECTORY_SEPARATOR instead of '/' or
define('DS', DIRECTORY_SEPARATOR);

then DS instead of '/'


Reply to this email directly or view it on GitHub
#15 (comment).

@Wayn0
Copy link

Wayn0 commented Apr 9, 2015

My bad, should have read your comment first. I just had problems a few years back using '/' on windows

hanxue added a commit to entrypass/php-obfuscator that referenced this pull request Apr 13, 2016
See naneau#15

Include native PHP copying, so that php-obfuscator will work on Windows
private function copyDirectory($src,$dst)
{
$dir = opendir($src);
@mkdir($dst);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably check the output of this method here, to avoid hard to debug errors down the line.

sha1 added a commit to sha1/php-obfuscator that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants